Quote:
Originally Posted by klaus
Hi Sarah,
I played a bit with your Bird source code, quite interesting.
A changed some parts, as suggestions, trying to simplify it.
Some comments:
- I needed to change manualy the content of the desktop.txt file with the default path. I suggest to change it to AppPath&"\"&pdata
|
To be honest I have never really understood the full implications of using the apppath command.
Quote:
- Your original Prefs.txt file contains 11 parameters, but when you save it you save only 9 parameters. You had no problem yet because you never really used the variables COMis and BAUDis, they are wrong after the first reading.
- I set a type for every variable. That's how I found the problem with the Prefs.txt file.
|
Yes, I understand. The preferences file was set out in an order so that it could be used by both the two types of GPS library. The standard GPS code requires Baud and Port values to be entered but the HTC GPS code auto-opens the port without these values being explicitly required. So the Htc code would not use these two values but the legacy standard GPS code would use them.
Quote:
- I removed the ImgBird control, it is not necessary. I use only Img1 for all images. When the image is smaller than the screen size there is no scrolling and the image can be scrolled when it is bigger than the screen size. In your code, only the big image could be scrolled but not the map neither and the photo.
- I changed the MouseMove routines for the images. In your program the image is flickering. I'm not shure if the way I did it now is what you wanted originaly.
|
Excellent work! I did the best I could and stay within the framework basic libraries used with b4ppc. And once the thing worked I moved on to another thing. I also found that, on the desktop the scrolled image flickered badly but didn't know how to stop it. The PDA version seemed to be ok.
Quote:
|
- I wouldn't have used a Panel and an Image to scroll the images but a BitmapEx object and drawing the appropriate part of the image directly onto the form using the ImageLibEx, but that's just my vision.
|
Well I appreciate you taking the time to improve this software, Klaus. I am impressed with your changes and will change the VGA version to match this one.
Quote:
|
- In the menu, what is MnuBird (Bird Topography) supposed to display. The program looks for a bird.jpg file in the PBEdata directory but there is none. I copied birdscape.jpg from the main directory to PBEdata and changed it's name.
|
This is the labeled jpg of a bird. On QVGA it can be scrolled to see all of the image.
Quote:
|
- Changed LatinOn and ShoPhotos to Boolean variables.
|
I always used -1 for true and 1 for false. So I could toggle them like a switch with x = -x. It is why I haven't used the True/False assignments (I think these are 1 and 0).
Quote:
|
- For the preferences I would have used a specific form with all the parameters visible at once and possible to chage them, instead of having them in the menu.
|
If I had known how many options would be asked for in the program I would have had a form/page with all the options on it too! In fact, I agree with you and I may just change this to an options form. It would tidy up the soft menu area.
Quote:
All the point above are suggestions and just my point of view.
Attached your qvga version 4.4.0, based on your version 4.3.1.
I don't have tested everything, perhaps there are some bugs. I tested it only on the desktop.
I'm almost shure that you could have 1 source code for the 3 configurations but I haven't looked at the differences in your source files yet.
Best regards.
|
The reason I have not been able to use a single source code, Klaus is due to using GPS code. For some reason you cannot use both GPS libraries (standard GPS and HTC GPS) and code in the one source file. It will not compile with both GPS types in the same source code.
Thanks, Klaus, for your excellent input and improvements. I will most certainly use them.
Sarah
Linear Mode
